Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: damage console messages #3043

Closed
wants to merge 8 commits into from

Conversation

Aerwix
Copy link
Contributor

@Aerwix Aerwix commented Oct 31, 2024

I think I managed to fix all the message consoles that were having double space and now it's showing correctly. I took time to figure out all the methods and text might be not correct so please check them and take my PR as reference.

This PR fix messages for Health and Mana cases =D

Errors were showing like this:
image

And now after this changes, they look like this:

Attacker
image

Target
image

Spectator
image

@murilo09 murilo09 changed the title Fix: dmg console mesagges (Health and Mana) Fix: damage console messages Nov 1, 2024
@dudantas dudantas changed the title Fix: damage console messages fix: damage console messages Nov 2, 2024
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please convert the cases that you are updating to use fmt instead of stringstream?

Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

@github-actions github-actions bot removed the Stale No activity label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants