-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: damage console messages #3043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please convert the cases that you are updating to use fmt instead of stringstream?
Quality Gate passedIssues Measures |
This PR is stale because it has been open 45 days with no activity. |
Quality Gate passedIssues Measures |
I think I managed to fix all the message consoles that were having double space and now it's showing correctly. I took time to figure out all the methods and text might be not correct so please check them and take my PR as reference.
This PR fix messages for Health and Mana cases =D
Errors were showing like this:
And now after this changes, they look like this:
Attacker
Target
Spectator